Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align versions of Python@3.10.9 and Poetry@1.3.2 #522

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Align versions of Python@3.10.9 and Poetry@1.3.2 #522

merged 4 commits into from
Jan 30, 2023

Conversation

grahamalama
Copy link
Contributor

No description provided.

@grahamalama grahamalama requested a review from a team as a code owner January 26, 2023 21:22
@grahamalama grahamalama added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Jan 26, 2023
@leplatrem
Copy link
Contributor

Could we add a few lines of docs, at least mentioning a sed command to update all occurences at once?

@grahamalama grahamalama force-pushed the bump-python-and-poetry branch from d38d032 to d504f8f Compare January 28, 2023 14:34
leplatrem
leplatrem approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we'll eventually end up in a situation where the PR to upgrade Python in the container gets merged without having updated the Github Actions. But I don't think there's much we can do, and implementing CI checks for this seems overkill.

docs/developer_setup.md Outdated Show resolved Hide resolved
@grahamalama grahamalama force-pushed the bump-python-and-poetry branch from d504f8f to cd15ce5 Compare January 30, 2023 15:10
@grahamalama grahamalama merged commit f8a4c3d into main Jan 30, 2023
@grahamalama grahamalama deleted the bump-python-and-poetry branch January 30, 2023 15:15
@grahamalama grahamalama mentioned this pull request Jul 11, 2023
Merged
leplatrem added a commit that referenced this pull request Jul 11, 2023
@leplatrem
Restore sections added in #522
4b3efea
leplatrem added a commit that referenced this pull request Jul 11, 2023
@leplatrem
Slim down developer docs (#755)
e05f31e 
* Slim down developer docs

The docs should be focused on the specificities of the project, and not duplicate the docs of the different tools that we use.

* Restore sections added in #522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leplatrem leplatrem leplatrem approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamalama @leplatrem